Re-configure GitLab deployment jobs#11757
Open
sarahchen6 wants to merge 3 commits into
Open
Conversation
sarahchen6
added
type: enhancement
sarahchen6
requested review from
bric3 and
randomanderson
and removed request for
a team
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Reconfigure Maven and GitHub deployment jobs to run after GitLab system-tests succeed.
OCI publishing and GitHub deployments both depend on Maven publishing to first succeed. GitLab system-tests and OCI image publishing are in the same
shared-pipelinestage. Thus, this PR separates GitLab system-tests and its necessary jobs to a separateshared-pipeline-system-testsstage that occurs before thepublishstage where Maven / GitHub publishing jobs run.Motivation
In release 1.63.1 where GitLab system-tests failed, Maven and GitHub artifacts were deployed while OCI artifacts were not because only OCI artifacts depended on system-tests success. Ensure that publishing steps occur in line with each other after system-tests succeed.
Additional Notes
Check the effects of the changes in this PR by going to the GitLab pipeline, clicking "Job dependencies" and toggling "Show dependencies" (https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/pipelines/121679382).
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]